Skip to content

Conversation

@euprunin
Copy link
Collaborator

@euprunin euprunin commented Jan 6, 2026


The goal of this golfing PR is to decrease the number of times lemmas are called explicitly (replacing calls to lemmas with calls to tactics). Any decrease in compilation time is a welcome side effect, although it is not a primary objective.

Trace profiling results (shown if ≥10 ms before or after):

  • Orientation.nonneg_inner_and_areaForm_eq_zero_iff_sameRay: 287 ms before, 336 ms after
  • PFunctor.liftr_iff: 49 ms before, 93 ms after
  • IsAdjoinRootMonic.coeff_root_pow: 119 ms before, 267 ms after

This golfing PR is batched under the following guidelines:

  • Up to ~5 changed files per PR
  • Up to ~25 changed declarations per PR
  • Up to ~100 changed lines per PR

Open in Gitpod

@euprunin
Copy link
Collaborator Author

euprunin commented Jan 6, 2026

!bench

@leanprover-radar
Copy link

leanprover-radar commented Jan 6, 2026

Benchmark results for 1a292b1 against 9e47581 are in! @euprunin

Small changes (1🟥)
  • 🟥 build/module/Mathlib.RingTheory.IsAdjoinRoot//instructions: +1.4G (+2.8%)

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

PR summary 9e4758124b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants