Skip to content

Conversation

@joneugster
Copy link
Collaborator

@joneugster joneugster commented Jun 20, 2024


The porting note was introduced in the generalisation from def uncurry : (M →ₗ[R] N →ₗ[R] P) →ₗ[R] M ⊗[R] N →ₗ[R] P to def uncurry : (M →ₗ[A] N →ₗ[R] P) →ₗ[B] M ⊗[R] N →ₗ[A] P in #6035 by @eric-wieser.

Actually I'm unsure if there is still a use for these porting notes describing the in #align. If so, they could be categorised instead...

Open in Gitpod

@joneugster joneugster added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. and removed awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 20, 2024
@github-actions
Copy link

PR summary eeac62e464

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@grunweg
Copy link
Collaborator

grunweg commented Jun 21, 2024

I don't see why these porting notes are useful and removing them is fine. I would appreciate a second opinion... so let's
maintainer merge

Thanks for doing all these small clean-ups around porting notes!

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 21, 2024
@kmill
Copy link
Contributor

kmill commented Jun 22, 2024

I could be wrong, but I believe these notes are not necessary. I'll just go ahead and merge...

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 22, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(LinearAlgebra/TensorProduct/Tower): remove superfluous porting notes [Merged by Bors] - chore(LinearAlgebra/TensorProduct/Tower): remove superfluous porting notes Jun 22, 2024
@mathlib-bors mathlib-bors bot closed this Jun 22, 2024
@mathlib-bors mathlib-bors bot deleted the eugster/porting-notes-009 branch June 22, 2024 19:57
@eric-wieser
Copy link
Member

eric-wieser commented Jun 22, 2024

The idea was that this note might help someone using mathport to convert their project, but removing it now almost a year later is probably fine.

Generally I'd be inclined to just leave these and remove them alongside the aligns when that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants