-
Notifications
You must be signed in to change notification settings - Fork 981
[Merged by Bors] - chore(LinearAlgebra/TensorProduct/Tower): remove superfluous porting notes #13987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary eeac62e464Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
|
I don't see why these porting notes are useful and removing them is fine. I would appreciate a second opinion... so let's Thanks for doing all these small clean-ups around porting notes! |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
|
I could be wrong, but I believe these notes are not necessary. I'll just go ahead and merge... bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
|
The idea was that this note might help someone using mathport to convert their project, but removing it now almost a year later is probably fine. Generally I'd be inclined to just leave these and remove them alongside the aligns when that happens. |
The porting note was introduced in the generalisation from
def uncurry : (M →ₗ[R] N →ₗ[R] P) →ₗ[R] M ⊗[R] N →ₗ[R] Ptodef uncurry : (M →ₗ[A] N →ₗ[R] P) →ₗ[B] M ⊗[R] N →ₗ[A] Pin #6035 by @eric-wieser.Actually I'm unsure if there is still a use for these porting notes describing the
ₓin#align. If so, they could be categorised instead...