Sundry fixes #9
Open
Sundry fixes #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ekkis
commented
May 2, 2022
ekkis
commented
- added currency support
- enhanced country list, as per official documentation
- now does proper validation on partner ID and credentials
- fixed tests (but they need proper credentials)
- enhancements to constructor
- ABC: card creation must now be passed a country code instead of a region. currency no longer passed (derived internally)
- updated documentation
added 9 commits
May 1, 2022 18:17
- enhanced country list, as per official documentation - now does proper validation on partner ID and credentials - fixed tests (but they need proper credentials) - enhancements to constructor - ABC: card creation must now be passed a country code instead of a region. currency no longer passed (derived internally) - updated documentation
the default template must be sourced from the project itself, not the client's config directory as the template is maintained by this project, not the client
'sandbox' is not a valid NODE_ENV value
- replaced deprecated 'request' with standard 'node-fetch' - implemented promises, maintaining support for callbacks - APB: public functions no longer return debugging information as this is returned in the promise or callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.