Skip to content

Make ImportCommand service lazy to prevent database connection on Symfony cache clear #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thislg merged 4 commits into from
Dec 11, 2025
Merged

Make ImportCommand service lazy to prevent database connection on Symfony cache clear #52

thislg merged 4 commits into from
Dec 11, 2025

Conversation

@pierreboissinot
Copy link
Member

@pierreboissinot pierreboissinot commented Dec 11, 2025

No description provided.

@thislg thislg self-requested a review December 11, 2025 14:00
@lucasmirloup
Copy link
Member

lucasmirloup commented Dec 11, 2025 •
edited
Loading

Merci Pierre 👍

Pour info, en Symfony 8+, si je ne dis pas de bêtises, les commandes migrées en __invoke() (faisable à l'aide de Rector) deviennent lazy par défaut.

@pierreboissinot
Copy link
Member Author

pierreboissinot commented Dec 11, 2025 •
edited
Loading

Merci Pierre 👍

Pour info, en Symfony 8+, si je ne dis pas de bêtises, les commandes migrées en __invoke() (faisable à l'aide de Rector) deviennent lazy par défaut.

Sûrement, il y a aussi l'attribute AsCommand qui remplace la prop static defaultName mais je ne voulais pas faire de bc break par rapport au support de PHP 7

lucasmirloup
lucasmirloup approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@lucasmirloup lucasmirloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thislg
Copy link
Member

thislg commented Dec 11, 2025

On supporte Symfony 5.4 et plus.

thislg
thislg reviewed Dec 11, 2025
View reviewed changes
Copy link
Member

@thislg thislg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK à part une question.

@thislg thislg self-requested a review December 11, 2025 16:07
@thislg thislg merged commit 5c89f70 into master Dec 11, 2025
7 checks passed
@thislg thislg deleted the service-lazy branch December 11, 2025 16:08
@github-actions github-actions bot mentioned this pull request Dec 8, 2025
Merged
@pierreboissinot pierreboissinot mentioned this pull request Dec 11, 2025
Merged
@github-actions github-actions bot mentioned this pull request Dec 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thislg thislg thislg approved these changes

@lucasmirloup lucasmirloup lucasmirloup approved these changes

@afrancois-lephare afrancois-lephare Awaiting requested review from afrancois-lephare

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierreboissinot @lucasmirloup @thislg