Rotation Crash on TagSubstitutionBlock #814
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Raycoms
reviewed
Jan 23, 2026
| } | ||
|
|
||
| // If the rotated state cannot host a BE, drop any BE tag (prevents renderer/loader issues). | ||
| if (!rotatedState.hasBlockEntity()) |
Contributor
There was a problem hiding this comment.
Can it happen that we get serializedBE not empty but it has no block entity?
Author
There was a problem hiding this comment.
What I saw when debugging was that for this specific decoration the block entity was reported as "present but blank" - showed up as "{}" when dumping the logs. Not sure how that comes about... but wanted to guard against it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #813
Changes proposed in this pull request
Testing
I was able to reproduce the crash and confirm that after the fix it was eliminated.
I did a number of other tests using the TagSubstitutionBlock. I did note that if the TSB is put on a chest that the rotation of the chest was NOT correctly reflected (the position was, but not the facing). I did confirm that contents were persisted as well.
After a number of attempts to explore fixes, I decided to submit this small improvement (no crash) despite the lack of proper chest orientation post-rotation.
Review please