Add sop-onboard skill and agent for project onboarding#36
Add sop-onboard skill and agent for project onboarding#36
Conversation
New skill provides a step-by-step playbook for setting up dev-sop-engine in any project. New agent acts as an autonomous onboarding assistant that follows the playbook to scaffold sop/ and generate .claude/ config. Closes #35 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ldraney
left a comment
There was a problem hiding this comment.
Review Notes
Good
- Thorough step-by-step playbook, well-structured flow (analyze → issue → branch → scaffold → generate → verify → PR)
- Agent prompt has a solid decision framework for when to add rules/MCP/skills/agents
- "Start minimal" philosophy is sound
- Tested on a real project (ebay-sdk PR #12)
Issues / Suggestions
-
Whitespace-only reformatting in sop.json — The diff expands single-line arrays to multi-line throughout. This noise makes actual changes harder to review. Consider separating formatting from functional changes.
-
.current-issuechanged from6to35— Should this file be in.gitignore? Looks like transient state. -
Script copying underspecified (Step 6) — Says "Copy from dev-sop-engine's reference implementation" but doesn't say how. A new user wouldn't know where to get
engine.sh,no-main-commit.sh, orlog-event.sh. This is the weakest part of the playbook. -
No mention of CLAUDE.md — The playbook doesn't address setting up a project's
CLAUDE.md, which is a key part of Claude Code configuration. -
Skill is 197 lines — Not a blocker, but the agent consumes all of it each time it's invoked.
🤖 Generated with Claude Code
Summary
/sop-onboardskill: step-by-step playbook for setting up dev-sop-engine in any projectsop-onboardagent: autonomous onboarding assistant that follows the playbook~/ebay-sdk(see Set up dev-sop-engine for project configuration ebay-sdk#12)Test plan
.claude/skills/sop-onboard/SKILL.mdgenerated with correct content.claude/agents/sop-onboard.mdgenerated with YAML frontmatter~/ebay-sdk/.claude/generated from its ownsop/sop.jsonCloses #35
🤖 Generated with Claude Code