Skip to content

Add sop-onboard skill and agent for project onboarding#36

Open
ldraney wants to merge 1 commit intomainfrom
35-sop-onboard-skill-and-agent
Open

Add sop-onboard skill and agent for project onboarding#36
ldraney wants to merge 1 commit intomainfrom
35-sop-onboard-skill-and-agent

Conversation

@ldraney
Copy link
Owner

@ldraney ldraney commented Feb 2, 2026

Summary

Test plan

Closes #35

🤖 Generated with Claude Code

New skill provides a step-by-step playbook for setting up dev-sop-engine
in any project. New agent acts as an autonomous onboarding assistant that
follows the playbook to scaffold sop/ and generate .claude/ config.

Closes #35

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Owner Author

@ldraney ldraney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Notes

Good

  • Thorough step-by-step playbook, well-structured flow (analyze → issue → branch → scaffold → generate → verify → PR)
  • Agent prompt has a solid decision framework for when to add rules/MCP/skills/agents
  • "Start minimal" philosophy is sound
  • Tested on a real project (ebay-sdk PR #12)

Issues / Suggestions

  1. Whitespace-only reformatting in sop.json — The diff expands single-line arrays to multi-line throughout. This noise makes actual changes harder to review. Consider separating formatting from functional changes.

  2. .current-issue changed from 6 to 35 — Should this file be in .gitignore? Looks like transient state.

  3. Script copying underspecified (Step 6) — Says "Copy from dev-sop-engine's reference implementation" but doesn't say how. A new user wouldn't know where to get engine.sh, no-main-commit.sh, or log-event.sh. This is the weakest part of the playbook.

  4. No mention of CLAUDE.md — The playbook doesn't address setting up a project's CLAUDE.md, which is a key part of Claude Code configuration.

  5. Skill is 197 lines — Not a blocker, but the agent consumes all of it each time it's invoked.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sop-onboard skill and agent for project onboarding

1 participant