Merged
Conversation
… MS Store Sysinternals packages
…onal safety checks
* Improve CIDR validation logic for IPv4 addresses * Add test cases for 0.0.0.0/1 CIDR notation This commit introduces new test cases in the `ValidateTests.cs` file for the following methods: - `ValidIpv4ORCIDR` - `ValidIpv4ORIpv6ORCIDR` - `ValidIpv4CIDR` Each test case includes the data row `0.0.0.0/1` to ensure proper validation of this CIDR notation. * Update development pipeline to run for all branches other than main * Adds support for validating CIDR 0.0.0.0/0 Updates test cases in to cover new scenarios for both invalid and valid IPv4 and CIDR inputs. Removed some duplicate DataRow test cases. * Refactor IP address validation methods Renamed validation methods in the `Validate` class to differentiate valid endpoint addresses from other valid address formats. Updated usages of the validation code where appropriate to differentiate between when the code path wanted to check for a valid IP Address in the context of an endpoint vs a route (where things like 0.0.0.0 would be allowed) Refactored main IP address validation logic to use a single internal function to ensure consistency of validation across address types. Test cases in `ValidateTests.cs` were modified to reflect the new method names and ensure proper functionality. * Rename validation tests for IPv4 and IPv6 endpoints * Update ValidateIPInternal logic to not use ternary expression Add validation for rejecting non v4 or v6 address families Moves CIDR validation routines to use new internal address validation method --------- Co-authored-by: Leo D'Arcy <leo.darcy@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: