Added similar artists property to bands#15
Open
msanlop wants to merge 2 commits intolcharlick:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for resubmiting I just learned that github only allows 1 account and ppl got banned so I wanna play it safe.
Added similar artists property that fetches the Similar Artists tab on a band's page.
Also added an example in the README.
commented requests_cache.core, doesn't exist (?!)
Usage preview:
This only gets the first 'batch', I'll probably add the option to get the 'see more' bands when I get the time.
Cheers
PS: I had to comment out 2 lines with requests_cache.core because it doesn't seem to work for me idk... I submitted an issue. And some of the tests are outdated with the data on the site.