Make XAxis and YAxis extend an Axis class#28
Open
pongloongyeat wants to merge 2 commits intolcallarec:masterfrom
Open
Make XAxis and YAxis extend an Axis class#28pongloongyeat wants to merge 2 commits intolcallarec:masterfrom
pongloongyeat wants to merge 2 commits intolcallarec:masterfrom
Conversation
Owner
|
Thanks for your contribution. Looks good, but I just would like to take time to give a look at this change 80a81e2#diff-8fc8cc80e5f6ea3a23ffe66932e4d44d1bfaadba3bf8bf0eb43a1d2e66dfff54L34. I'm not sure if it can broke something or not. Even if the coverage is pretty good, everything is not unit tested yet. |
Author
|
Ahhh I may want to give it a default value then. |
Author
|
@lcallarec take your time. For now, I'll give it a default value so it can fallback to something. I believe YAxis uses a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title implies. All tests passed.