Update .gitignore and config.yaml; remove obsolete metadata files and…#17
Merged
Update .gitignore and config.yaml; remove obsolete metadata files and…#17
Conversation
… adjust trading fee
There was a problem hiding this comment.
Pull request overview
This PR updates the project's .gitignore patterns and adjusts the trading fee configuration, while removing obsolete cached metadata files that will be automatically regenerated.
Key Changes:
- Increased trading costs from 10 bps to 25 bps (0.25%) to reflect more realistic transaction costs
- Enhanced .gitignore patterns to recursively ignore all cached data files (parquet/csv) and HTML reports
- Removed cached metadata files (prices_metadata.csv, risk_free_rate.parquet) that are automatically regenerated
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| config.yaml | Updated trading_fee_bps from 10 to 25 basis points for more realistic cost modeling |
| .gitignore | Enhanced patterns to recursively ignore all parquet/csv files in data/ and HTML reports in output/, moved docs/private/ entry to Environments section |
| data/prices_metadata.csv | Removed cached metadata file (automatically regenerated by DataDownloader.cache_to_disk()) |
| data/risk_free_rate.parquet | Removed cached risk-free rate data (now covered by .gitignore patterns, regenerated from FRED) |
| frequency: "quarterly" # Options: daily, weekly, monthly, quarterly, annual | ||
| method: "calendar" # calendar = rebalance at end of period | ||
| trading_fee_bps: 10 # Trading cost in basis points per turnover (10 bps = 0.10%) | ||
| trading_fee_bps: 25 # Trading cost in basis points per turnover (10 bps = 0.10%) |
There was a problem hiding this comment.
The comment still states "10 bps = 0.10%" as an example, but this is now outdated since the value changed to 25 bps. The comment should be updated to reflect the new value: "Trading cost in basis points per turnover (25 bps = 0.25%)".
Suggested change
| trading_fee_bps: 25 # Trading cost in basis points per turnover (10 bps = 0.10%) | |
| trading_fee_bps: 25 # Trading cost in basis points per turnover (25 bps = 0.25%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… adjust trading fee