Skip to content

Updated carbone types options with missing fields #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lbanders wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated carbone types options with missing fields #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cba4c1
Updated carbone types options with missing fields
lbanders Sep 12, 2022
fdfc022
Updated carbone tests with new fields
lbanders Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions types/carbone/carbone-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ const lang = 'pl';
const timezone = 'Asia/Tokyo';
const tempPath = '/tmp';
const templatePath = './templates';
const factories = 2;
const startFactory = true;
const attempts = 2;

const emptyCurrencyRates = {};
const currencyRates = {
Expand Down Expand Up @@ -68,6 +71,9 @@ const options: carbone.Options = {
currencySource,
currencyTarget,
currencyRates,
factories,
startFactory,
attempts
};

const emptyRenderOptions: carbone.RenderOptions = {};
Expand Down
3 changes: 3 additions & 0 deletions types/carbone/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ export interface Options {
currencySource?: string | undefined;
currencyTarget?: string | undefined;
currencyRates?: CurrencyRates | undefined;
factories?: number | undefined;
startFactory?: boolean | undefined;
attempts?: number | undefined;
}
export function set(options: Options): void;
export function reset(): void;
Expand Down