Skip to content

MAPS, WADS: Fixed sky_test error in ericw tools#184

Closed
Zungrysoft wants to merge 1 commit intomainfrom
zungryware/test_sky_fix
Closed

MAPS, WADS: Fixed sky_test error in ericw tools#184
Zungrysoft wants to merge 1 commit intomainfrom
zungryware/test_sky_fix

Conversation

@Zungrysoft
Copy link
Collaborator

Description of Changes


Fixed a CI error with sky_test giving a warning about a missing texture. Replacing the hyphen with an underscore fixes this for some reason.

Checklist


  • I have read the LibreQuake contribution guidelines
  • I have thoroughly tested my changes to the best of my ability
  • I confirm I have not contributed anything that would impact LibreQuake's licensing and usage
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible

@lavenderdotpet
Copy link
Owner

just remove the texture and replace the name with the proper one that file was only made when I was testing some stuff

@lavenderdotpet
Copy link
Owner

lavenderdotpet commented Oct 12, 2024

or I'll take care of it when I wake up

the work is already done on the branch I just have to move it to a new pull req when I get back to my pc in the morning

@Zungrysoft
Copy link
Collaborator Author

the work is already done on the branch I just have to move it to a new pull req when I get back to my pc in the morning

Alright. That sounds good. Though the CI is still failing and I have no idea why.

@Zungrysoft Zungrysoft closed this Oct 12, 2024
@lavenderdotpet
Copy link
Owner

#130

SmartSelect_20241013_001611_Firefox.jpg

it's fine here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants