serve minified sw-register.js and inline script#24
Open
souldanger wants to merge 3 commits intolavas-project:masterfrom
Open
serve minified sw-register.js and inline script#24souldanger wants to merge 3 commits intolavas-project:masterfrom
souldanger wants to merge 3 commits intolavas-project:masterfrom
Conversation
Contributor
|
Sorry, I'll merge this PR in 10 days because of Chinese Spring Festival. |
Contributor
|
Where should we store the source code of |
Collaborator
Author
|
No problem - have a fantastic festival!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have minified sw-register.js and the corresponding inline script.
This is to satisfy technical SEO audits w/ i.e. GTmetrics and others, it does not significantly improve the performance as such. The achievement is a handful of ms at the most...
In my case, when building a website/pwa for a client, I always hand out a technical SEO report to prove that the latest, best and fastest technologies have been used. Minifying the above scripts helps getting a better performance rating...