Skip to content

fix: Remove direct dependency on LaunchDarkly.InternalSdk #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsonbailey merged 1 commit into from
Jan 8, 2026
Merged

fix: Remove direct dependency on LaunchDarkly.InternalSdk #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/LaunchDarkly.OpenFeature.ServerProvider/Provider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System.Threading.Tasks;
using LaunchDarkly.Logging;
using LaunchDarkly.Sdk;
using LaunchDarkly.Sdk.Internal.Concurrent;
using LaunchDarkly.Sdk.Server;
using LaunchDarkly.Sdk.Server.Interfaces;
using OpenFeature;
Expand Down Expand Up @@ -32,7 +31,8 @@ public sealed partial class Provider : FeatureProvider
private readonly EvalContextConverter _contextConverter;
private readonly StatusProvider _statusProvider;

private readonly AtomicBoolean _initializeCalled = new AtomicBoolean(false);
private readonly object _initLock = new object();
private bool _initializeCalled = false;

// There is no support for void task completion, so we use bool as a dummy result type.
private readonly TaskCompletionSource<bool> _initCompletion = new TaskCompletionSource<bool>();
Expand Down Expand Up @@ -130,9 +130,13 @@ public override Task<ResolutionDetails<Value>> ResolveStructureValueAsync(string
/// <inheritdoc />
public override Task InitializeAsync(EvaluationContext context, CancellationToken cancellationToken = default)
{
if (_initializeCalled.GetAndSet(true))
lock (_initLock)
{
return _initCompletion.Task;
if (_initializeCalled)
{
return _initCompletion.Task;
}
_initializeCalled = true;
}

_client.FlagTracker.FlagChanged += FlagChangeHandler;
Expand Down