feat: Move datacompression dependency into local file #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| let wrong_crc = Data(bytes: [0xcafeabee], count: 1) | ||
| let range = (zipped_blob.count - 8)..<(zipped_blob.count - 4) | ||
| zipped_blob.replaceSubrange(range, with: wrong_crc) |
There was a problem hiding this comment.
Test corrupts gzip structure instead of checksum fields
Low Severity
The tests testGzipCrcFail and testGzipISizeFail claim to validate CRC32 and ISIZE checksum rejection, but Data(bytes: [0xcafeabee], count: 1) creates only 1 byte of data (due to count: 1). When replaceSubrange replaces a 4-byte range with 1 byte, the gzip data becomes 3 bytes shorter, corrupting the entire structure rather than just the checksum field. The tests pass but don't actually verify the intended validation logic.
Additional Locations (1)
tanderson-ld
approved these changes
Jan 21, 2026
abelonogov-ld
pushed a commit
that referenced
this pull request
Jan 22, 2026
🤖 I have created a release *beep* *boop* --- ## [11.1.0](11.0.0...11.1.0) (2026-01-21) ### Features * Move datacompression dependency into local file ([#469](#469)) ([860674b](860674b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Release 11.1.0** > > - *Feature*: Move `datacompression` dependency into a local file (see CHANGELOG) > - Bump versions to `11.1.0` across `podspec`, Xcode project settings (`MARKETING_VERSION`, `DYLIB_CURRENT_VERSION`), `ReportingConsts.sdkVersion`, `.release-please-manifest.json`, and README dependency snippets > - Update `CHANGELOG.md` with 11.1.0 notes > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4375a28. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Minus 1 external dependency to remove future version conflicts.
Address issue of version conflict in #449
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.
Note
Removes the external
DataCompressiondependency by inlining its functionality and switching the SDK to use a local compression implementation.DataCompressionfromPackage.swiftandLaunchDarkly.podspecLaunchDarkly/Extensions/Data+Compression.swiftprovidinggzip/gunzip,zip/unzip,deflate/inflate, and CRC/Adler32 helpers; exposesData.ld_gzip()for call sitesDarklyServiceto useld_gzip()whenenableCompressionis onCompressionTestcovering gzip roundtrips, checksum validation, and large/random data casesWritten by Cursor Bugbot for commit df39bef. This will update automatically on new commits. Configure here.