Make min_year and max_year configurable #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For systems with limited memory resources, they may not want all of the time data created by default as it increases the size of the ETS table
Make min_year and max_year configurable
PeterJeaiem
reviewed
Feb 13, 2024
| size of the ets table created by `:tzdata`. | ||
|
|
||
| ```elixir | ||
| config :tzdata, :max_year, 2030 |
There was a problem hiding this comment.
isnt' that a bit too close for comfort ?
Author
There was a problem hiding this comment.
What do you mean? Bearing in mind that this is just an example in the README, it is not in the code.
There was a problem hiding this comment.
ah missed the README part, nevermind
There was a problem hiding this comment.
what is it actually configured to on the system ?
metelik
approved these changes
Feb 13, 2024
PeterJeaiem
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For systems with limited memory resources, they may not want all of the time data created by default as it increases the size of the ETS table