Skip to content

fix: add pytest and pytest-cov to dev dependencies#28

Merged
LanusseMorais merged 1 commit intomainfrom
fix/ci-always-install-dependencies
Mar 26, 2026
Merged

fix: add pytest and pytest-cov to dev dependencies#28
LanusseMorais merged 1 commit intomainfrom
fix/ci-always-install-dependencies

Conversation

@LanusseMorais
Copy link
Contributor

@LanusseMorais LanusseMorais commented Mar 26, 2026

Summary

  • Root cause: pytest was never declared as a dependency in pyproject.toml — only [tool.pytest.ini_options] config existed
  • Tests passed before because a stale .venv cache happened to contain pytest from a previous manual install
  • Added pytest >= 8.0.0 and pytest-cov >= 5.0.0 to [tool.poetry.group.dev.dependencies]
  • This should unblock integration tests on PR chore: 🐝 Update SDK - Generate 3.0.1 #26

Context

PR #27 removed the conditional if: cache-hit != 'true' on poetry install, but that alone didn't fix the issue because poetry install correctly reports "No dependencies to install" when pytest isn't in the lock file.


Note

Low Risk
Low risk: changes are limited to development/testing dependencies and poetry.lock regeneration, with no runtime code or production dependency changes.

Overview
Ensures the test runner is installed consistently by adding pytest and pytest-cov to [tool.poetry.group.dev.dependencies].

Regenerates poetry.lock to include pytest, pytest-cov, and their transitive dev-only dependencies (e.g., coverage, pluggy, iniconfig, packaging, pygments), and updates lock metadata (including the Poetry generator/version header).

Written by Cursor Bugbot for commit 838bf9b. This will update automatically on new commits. Configure here.

@LanusseMorais LanusseMorais force-pushed the fix/ci-always-install-dependencies branch from 7e86e89 to 838bf9b Compare March 26, 2026 22:57
@LanusseMorais LanusseMorais merged commit 8bb98c2 into main Mar 26, 2026
5 checks passed
@LanusseMorais LanusseMorais deleted the fix/ci-always-install-dependencies branch March 26, 2026 23:02
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

pylint = "==3.2.3"
pyright = "==1.1.398"
pytest = ">=8.0.0"
pytest-cov = ">=5.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbounded version constraints resolved to unexpected major versions

Low Severity

The pytest and pytest-cov constraints use >= (unbounded) while all other dev dependencies (mypy, pylint, pyright) use exact == pins. This inconsistency already caused the lock file to resolve pytest to 9.0.2 (a whole major version beyond the >= 8.0.0 floor) and pytest-cov to 7.1.0 (two major versions beyond >= 5.0.0). Using ^ or tighter bounds would prevent unintended major-version jumps on future lock regeneration and match the pinning strategy of the other dev dependencies.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants