Skip to content

Revisions for CRAN Upload #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
krisrs1128 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Revisions for CRAN Upload #32

krisrs1128 wants to merge 7 commits into from

Conversation

@krisrs1128
Copy link
Collaborator

@krisrs1128 krisrs1128 commented Apr 28, 2024

  • Updates documentation to remove the two devtools::check() warnings.
  • Adds reference to our paper on the README page.
  • Suppresses package startup messages in all the vignettes.
  • Computes distances on JSD, not log-transformed version. The optimal transport code had thrown a new error in the basic_alignment.Rmd vignette (line 176) which pointed me to this issue.

@krisrs1128 krisrs1128 requested a review from lasy May 25, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lasy lasy Awaiting requested review from lasy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krisrs1128