Skip to content

fix: move padding from Drawer content to individual sections#18

Merged
Fernando Jesus (fernandorjesus) merged 1 commit intomainfrom
fix/drawer-section-spacing
Mar 26, 2026
Merged

fix: move padding from Drawer content to individual sections#18
Fernando Jesus (fernandorjesus) merged 1 commit intomainfrom
fix/drawer-section-spacing

Conversation

@fernandorjesus
Copy link
Copy Markdown
Collaborator

@fernandorjesus Fernando Jesus (fernandorjesus) commented Mar 26, 2026

Summary

  • Move horizontal padding (px-8) and gap from DrawerContent wrapper to DrawerHeader, DrawerMain, and DrawerFooter individually
  • Change DrawerContent from p-8 gap-6 to py-8 so sections control their own horizontal padding and vertical spacing
  • Add top border separator (border-t border-gray-300) to DrawerFooter

Test plan

  • Verify Drawer opens correctly in all directions (top, bottom, left, right)
  • Confirm header, main content, and footer spacing looks correct
  • Verify footer border separator renders properly
  • Check that scrollable content in DrawerMain still works with new padding

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Refined drawer spacing with improved padding distribution across header, main content, and footer sections.
    • Added visual separator to drawer footer for better visual hierarchy.

Move horizontal padding and gap from the shared content wrapper to
DrawerHeader, DrawerMain, and DrawerFooter so each section controls
its own spacing. Add a top border separator to DrawerFooter.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d8354f05-b576-4df3-a407-6416cf9203f8

📥 Commits

Reviewing files that changed from the base of the PR and between fbeaeb1 and 9f34d4a.

📒 Files selected for processing (1)
  • src/components/ui/Drawer/Drawer.tsx

Walkthrough

I pity the fool who don't listen up! The drawer component's padding layout gets restructured, sucka—uniform p-8 on DrawerContent gets replaced with distributed padding across DrawerHeader (px-8 pb-6), DrawerMain (px-8 py-6), and DrawerFooter (p-8 pb-0 with top border). No control flow or API changes, fool!

Changes

Cohort / File(s) Summary
Drawer Spacing Refactor
src/components/ui/Drawer/Drawer.tsx
Padding redistributed from DrawerContent to subcomponents. DrawerHeader and DrawerMain receive horizontal padding (px-8), while DrawerFooter adds top border styling (border-t border-gray-300) and conditional padding. No API changes, I say!

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Fool! This ain't no complex logic—just spacing adjustments, sucker!

Poem

📦 Padding gets distributed with precision,
Spacing flows through each section's vision,
DrawerContent steps back with grace,
Subcomponents claim their rightful place,
Layout harmony, fool! No control's displaced! 🎨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description provides a clear summary of changes and test plan, but lacks required template sections like 'What changed?' heading and 'Screenshots' section. Restructure the description to match the template format with 'What changed?' and 'Screenshots' sections, and complete the Storybook and testing checklist items.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: moving padding from the Drawer content wrapper to individual sections.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/drawer-section-spacing

Comment @coderabbitai help to get the list of available commands and usage tips.

@fernandorjesus Fernando Jesus (fernandorjesus) merged commit 52bb838 into main Mar 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants