Conversation
Allow users who can grant a badge to also remove it from others, and allow users to remove badges from themselves. Includes backend (store, API, slash command, notifications) and frontend (self-remove button in badge list, granter-remove button in badge details). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
larkox
left a comment
larkox
left a comment
There was a problem hiding this comment.
In general, LGTM. One thing that I would be careful about is about the multiple badges. Right now you are only deleting the first one you find in the ownership list. But since the same badge can be granted for different reasons, you may be deleting the one with the "wrong reason".
Right now ownership doesn't have any unique identifier, which is bad. But maybe we can use the Time, which should be "unique enough". What do you think?
We would need to pass an extra parameter to the request, and not sure how to handle that with the slash command, but it is something we should be careful about.
|
Hi, thanks for the fast response and sorry, the PR was not ready and I did not have time to test it thoroughly today. Good points you mentioned, I was thinking about that too today and wanted to do some extensive testing on how the UI feels when you have multiple badges from the same type assigned, etc; I'm just currently struggling with a compilation issue which I should also be able to fix next week and I'll post an update here then once the PR is ready (still a draft for the time being). |
|
Awesome. Ping me when you have it ready and I will take a look. Thank you very much for contributing! |
|
Crazy idea to handle the slash command... A slash command like |
2 participants
Allow users who can grant a badge to also remove it from others, and allow users to remove badges from themselves. Includes backend (store, API, slash command, notifications) and frontend (self-remove button in badge list, granter-remove button in badge details).