Skip to content

This fixes a set of warnings and other minor system-specific issues #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hkaiser wants to merge 3 commits into
base: 1
Choose a base branch
from
Open

This fixes a set of warnings and other minor system-specific issues #645

hkaiser wants to merge 3 commits into from

Conversation

@hkaiser
Copy link
Collaborator

@hkaiser hkaiser commented Oct 9, 2020

This separates the changes that are unrelated to HPX from #643

This patch fixes a set of warnings generated by various compilers:

  • integral conversion errors
  • possibly empty if statements
  • some performance warnings
  • etc.

This also applies workarounds for problems caused by MSVC:

  • min()/max() possibly being defined as macros
  • templates are being instantiated too eagerly

@hkaiser hkaiser mentioned this pull request Oct 9, 2020
Open
opensdh
opensdh reviewed Oct 9, 2020
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@opensdh opensdh opensdh left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hkaiser @opensdh