Ensuring compressed application size (Zip size) is within limits#265
Draft
mathiasgrimm wants to merge 2 commits intomasterfrom
Draft
Ensuring compressed application size (Zip size) is within limits#265mathiasgrimm wants to merge 2 commits intomasterfrom
mathiasgrimm wants to merge 2 commits intomasterfrom
Conversation
Before this PR we only checked for the decompressed application size (250 MB) but there's also a limit to the Zip file of 50 MB as per https://docs.aws.amazon.com/lambda/latest/dg/gettingstarted-limits.html. - Validating compressed file size - Small refactoring on `App\BuildProcess\CompressApplication` to avoid duplication when introducing the new validation. - Fixing invalid doc links
mathiasgrimm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR we only checked for the decompressed application size (250 MB) but there's also a limit to the Zip file of 50 MB as per AWS Docs, and when users run into this specific case they would not get any meaninful error message.
AWS would return a
400 Bad Requestwith the following messageCould not unzip uploaded file. Please check your file, then try to upload again.App\BuildProcess\CompressApplicationto avoid duplication when introducing the new validation.