Fix crash with method-only attributes on serialized closures#128
Draft
JoshSalway wants to merge 2 commits intolaravel:2.xfrom
Draft
Fix crash with method-only attributes on serialized closures#128JoshSalway wants to merge 2 commits intolaravel:2.xfrom
JoshSalway wants to merge 2 commits intolaravel:2.xfrom
Conversation
…ributes When a closure is created from a class method (e.g. `(new Foo)->bar(...)`), the method's attributes are inherited by the closure. Attributes that only target methods (like #[\Override]) would cause a fatal error when the serialized closure code is evaluated, because PHP rejects them on functions. This filters out attributes whose target flags don't include TARGET_FUNCTION before including them in the serialized closure code. Fixes laravel#110 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[\Override]) no longer cause fatal errors during deserializationTARGET_FUNCTIONbefore including them in the serialized closure codeTest plan
#[\Override]attribute on parent method (the exact reproduction case from the issue)🤖 Generated with Claude Code