Added screen resource with provider, supporting the usual actions#202
Open
nightw wants to merge 5 commits intolaradji:masterfrom
Open
Added screen resource with provider, supporting the usual actions#202nightw wants to merge 5 commits intolaradji:masterfrom
nightw wants to merge 5 commits intolaradji:masterfrom
Conversation
…s the ability to looking up the resources for the screenitems
… RuboCop offenses
Contributor
Author
|
Also corrected the RuboCop offenses. Now the test fails for some reason on Ruby 1.9 during bundle install, so it's not related to this pull request (and should be fixed separately). On Ruby2.0 the test passes. |
Contributor
Author
|
Could you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About half a year ago I've already submitted this change and ( #177 ) and @guilhem asked for a test for this. I've not provided it back then for a long time, so the Pull Request got closed without merging it. Sorry for taking so long, here is the change with a test case attached to it. :)
The test case is a bit big (installs MySQL, Zabbix, Zabbix web, etc. to be able to use the API for the LWRP), very specific (only works using Ubuntu 14.04 because of some package/cookbook breaking changes), but if it does not break, that means the screen resource could be created with this LWRP using the Zabbix API.
Please review (and run the test) and if you find it appropriate then merge it. Thanks.