Skip to content

Barkaysanoussisanoussi 201732120151 recently uploaded files #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sanoussibarkay wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Barkaysanoussisanoussi 201732120151 recently uploaded files #30

sanoussibarkay wants to merge 3 commits into from

Conversation

@sanoussibarkay
Copy link
Contributor

@sanoussibarkay sanoussibarkay commented Apr 19, 2020

image

@sanoussibarkay
new_functionality_recentlyuploaded_files_is_added(barkay sanoussi san…
cbf7cda 
…oussi--201732120151 ahamed sabuj--201732120141 hossain arif--201732120157 agonza lewis conrad--201732120140)
@sanoussibarkay
correction_new_functionality_recentlyuploaded_files_is_added(barkay s…
6eddf9c 
…anoussi sanoussi--201732120151 ahamed sabuj--201732120141 hossain arif--201732120157 agonza lewis conrad--201732120140)
@sanoussibarkay
new_functionality_recentlyuploaded_files_is_added(barkay sanoussi san…
63d65be 
…oussi--201732120151 ahamed sabuj--201732120141 hossain arif--201732120157 agonza lewis conrad--201732120140)
hema-001
hema-001 reviewed Apr 19, 2020
View reviewed changes
Copy link
Contributor

@hema-001 hema-001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. small, yet powerful feature to save time for a viewer who is not certain about a subject to start from in the website.

If you could add the popularity and likes count to the list, it might help the viewers to even better choose from the list.

Code wise, clean, straightforward, and easy to understand it took me less than 10 minutes to understand the newly added lines.

Thanks.

@hema-001 hema-001 requested a review from spm2020spring April 19, 2020 09:22
@sanoussibarkay
Copy link
Contributor Author

sanoussibarkay commented Apr 19, 2020

Good job. small, yet powerful feature to save time for a viewer who is not certain about a subject to start from in the website.
If you could add the popularity and likes count to the list, it might help the viewers to even better choose from the list.
Code wise, clean, straightforward, and easy to understand it took me less than 10 minutes to understand the newly added lines.
Thanks.

thank you for your comments ... good ideas i will implement them

spm2020spring
spm2020spring approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@spm2020spring spm2020spring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanoussibarkay

If everything works, please merge this branch to master.

Thanks

Hui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spm2020spring spm2020spring spm2020spring approved these changes

+1 more reviewer

@hema-001 hema-001 hema-001 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sanoussibarkay @hema-001 @spm2020spring