Skip to content

Add unit conversion inside mean opacity calls #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanWollaeger merged 1 commit into from
Mar 24, 2025
Merged

Add unit conversion inside mean opacity calls #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions singularity-opac/photons/non_cgs_photons.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ class MeanNonCGSUnits {
mass_unit_(mass_unit), length_unit_(length_unit), temp_unit_(temp_unit),
rho_unit_(mass_unit_ / (length_unit_ * length_unit_ * length_unit_)),
inv_emiss_unit_(length_unit_ * time_unit_ * time_unit_ * time_unit_ /
mass_unit_) {}
mass_unit_) {}

auto GetOnDevice() {
return MeanNonCGSUnits<MeanOpac>(mean_opac_.GetOnDevice(), time_unit_,
Expand Down Expand Up @@ -291,16 +291,17 @@ class MeanNonCGSUnits {

PORTABLE_INLINE_FUNCTION
Real AbsorptionCoefficient(const Real rho, const Real temp,
const int gmode = Rosseland) const {
const Real alpha = mean_opac_.AbsorptionCoefficient(rho, temp, gmode);
const int gmode = Rosseland) const {
const Real alpha = mean_opac_.AbsorptionCoefficient(
rho_unit_ * rho, temp_unit_ * temp, gmode);
return alpha * length_unit_;
}

PORTABLE_INLINE_FUNCTION
Real Emissivity(const Real rho, const Real temp,
const int gmode = Rosseland,
Real Emissivity(const Real rho, const Real temp, const int gmode = Rosseland,
Real *lambda = nullptr) const {
const Real J = mean_opac_.Emissivity(rho, temp, gmode);
const Real J =
mean_opac_.Emissivity(rho_unit_ * rho, temp_unit_ * temp, gmode);
return J * inv_emiss_unit_;
}

Expand Down