-
Notifications
You must be signed in to change notification settings - Fork 19
Add mass fraction multi-phase table to sesame2spiner #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Yurlungur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Glad it was a simple change. Regarding adding mass fractions to every EOS class... Broadly I'd be supportive of this, if we had an error message/stub in the base class as the default behavior. Clearly mass fractions aren't sensible for all EOS's but they are for enough EOS's we might want this.
It looks like the |
I believe Helmholtz does too... or if it doesn't, it could be exposed. |
…ssFraction and fill the string rather than the other way around
…d use the generic functions to do it
| std::vector<EOS_REAL> rhos, Ts, phs; | ||
| makeInterpPoints(rhos, lRhoBounds); | ||
| makeInterpPoints(Ts, lTBounds); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am re-using the EOS rho-T grid for this but in testing we are seeing that maybe that isn't great, e.g., instead of clustering around STP, we probably want to cluster the points around phase transitions. I could add another set of parameters to the inputs that describe the grid decomp for just mass fractions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes a lot of sense. Yeah there's no reason the two grids have to be the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're going to use different grids, I would just use the sesame grid. (piecewise linear). eospac just does bilinear interpolation for mass fractions so we should not need higher density than sesame.
PR Summary
This adds the mass fraction SESAME table to the spiner tables that sesame2spiner outputs (if it exists). Tested in a downstream code.
Putting this up now for an initial review.
I still need to add the mass fractions to the spiner EOS class. Are we okay with adding new
MassFractionFromDensityTemperaturefunctions to all EOS classes?Still TODO:
PR Checklist
make formatcommand after configuring withcmake.If preparing for a new release, in addition please check the following: