Skip to content

reworked task-lists, in PostInititalizationCommunications() #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jti-lanl wants to merge 3 commits into
base: main
Choose a base branch
from
Open

reworked task-lists, in PostInititalizationCommunications() #118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c68dd9c
Distinguish per-block vs MD tasks, in PostInititalizationCommunicatio…
jti-lanl Jun 14, 2022
096be76
Formatted with clang 12.0.1
jti-lanl Jun 14, 2022
d2bd33b
Separated the 3 init phases into 3 Regions, in PhoebusDriver::PIC()
jti-lanl Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 35 additions & 20 deletions src/phoebus_driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,36 +108,51 @@ void PhoebusDriver::PostInitializationCommunication() {
rad_mocmc_active = (rad->Param<std::string>("method") == "mocmc");
}

TaskRegion &async_region = tc.AddRegion(blocks.size());
// leading per-block tasks
TaskRegion &async_region0 = tc.AddRegion(1);
auto &tl0 = async_region0[0];
for (int ib = 0; ib < blocks.size(); ib++) {
auto pmb = blocks[ib].get();
auto &tl = async_region[ib];
auto &sc = pmb->meshblock_data.Get();
auto &md =
pmesh->mesh_data.GetOrAdd(stage_name[0], ib); // TODO(BRR) This gives an empty md

auto start_recv = tl.AddTask(none, &MeshBlockData<Real>::StartReceiving, sc.get(),
BoundaryCommSubset::all);
auto send =
tl.AddTask(start_recv, parthenon::cell_centered_bvars::SendBoundaryBuffers, md);
auto recv =
tl.AddTask(send, parthenon::cell_centered_bvars::ReceiveBoundaryBuffers, md);
auto fill_from_bufs =
tl.AddTask(recv, parthenon::cell_centered_bvars::SetBoundaries, md);
auto clear_comm_flags =
tl.AddTask(fill_from_bufs, &MeshBlockData<Real>::ClearBoundary, sc.get(),
BoundaryCommSubset::all);
auto start_recv = tl0.AddTask(none, &MeshBlockData<Real>::StartReceiving, sc.get(),
BoundaryCommSubset::all);
}

// tasks that span <md>
TaskRegion &async_region1 = tc.AddRegion(1);
auto &tl1 = async_region1[0];
auto &md = pmesh->mesh_data.GetOrAdd(stage_name[0], 0);

auto send = tl1.AddTask(none, parthenon::cell_centered_bvars::SendBoundaryBuffers, md);

auto recv =
tl1.AddTask(send, parthenon::cell_centered_bvars::ReceiveBoundaryBuffers, md);

auto fill_from_bufs =
tl1.AddTask(recv, parthenon::cell_centered_bvars::SetBoundaries, md);

// tailing per-block-tasks
TaskRegion &async_region2 = tc.AddRegion(1);
auto &tl2 = async_region2[0];
for (int ib = 0; ib < blocks.size(); ib++) {
auto pmb = blocks[ib].get();
auto &sc = pmb->meshblock_data.Get();

auto clear_comm_flags = tl2.AddTask(none, &MeshBlockData<Real>::ClearBoundary,
sc.get(), BoundaryCommSubset::all);

auto prolongBound = tl.AddTask(clear_comm_flags, parthenon::ProlongateBoundaries, sc);
auto prolongBound =
tl2.AddTask(clear_comm_flags, parthenon::ProlongateBoundaries, sc);

auto set_bc = tl.AddTask(prolongBound, parthenon::ApplyBoundaryConditions, sc);
auto set_bc = tl2.AddTask(prolongBound, parthenon::ApplyBoundaryConditions, sc);

auto convert_bc = tl.AddTask(set_bc, Boundaries::ConvertBoundaryConditions, sc);
auto convert_bc = tl2.AddTask(set_bc, Boundaries::ConvertBoundaryConditions, sc);

// Radiation should actually be included in ConvertBoundaryConditions
// using MDT = std::remove_pointer<decltype(sc.get())>::type;
// auto momentp2c = tl.AddTask(convert_bc, radiation::MomentPrim2Con<MDT>, sc.get(),
// IndexDomain::entire);
// auto momentp2c = tl2.AddTask(convert_bc, radiation::MomentPrim2Con<MDT>, sc.get(),
// IndexDomain::entire);
}

tc.Execute();
Expand Down