Refactor stopping times #45
Conversation
|
TODO:
|
| const Real cv = eos.SpecificHeatFromDensityTemperature(dg, Tg); | ||
| const Real gm1 = eos.GruneisenParamFromDensityTemperature(dg, Tg); | ||
| // kb T/ mu = cv * gm1 * T | ||
| const Real vth = std::sqrt(8.0 / M_PI * gm1 * cv * Tg); |
There was a problem hiding this comment.
Now that we have constants, we can just directly use kb/mu*T
…1 coordinate to the drag powerlaw model.
|
Why did this never get merged? |
The plan was to do some testing |
|
In src/drag/drag.hpp, in const Real CEu = 1. / (sgam * Mu) * (4.6 / (1. + M) + 1.7 /* srt(Td/Tg) */); we may want to apply the following correction: 4.6 -> (8/3)*sqrt(8/pi)~~4.25538612146777 which would provide the original Epstein drag limit. I was aware of the 4.6-4.26 discrepancy in Melosh & Goldin paper, but at the time, I decided to leave it and defer for later (I was working on planetesimals, so Epstein regime was irrelevant). I still don't know if it was a typo or something else. But I think we are OK reverting to the original Epstein formulation. |
Background
This does two things.
This relies on #44 .
Closes #41 .
Description of Changes
Checklist