Add Self-Gravity #113
Open
Add Self-Gravity #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+150
to
+155
| if (pin->DoesBlockExist("gravity/self")) { | ||
| count++; | ||
| gtype = GravityType::self; | ||
| block_name = "gravity/self"; | ||
| PARTHENON_REQUIRE(coords == Coordinates::cartesian, | ||
| "Self-gravity currently only supports Cartesian coordinates"); |
Collaborator
There was a problem hiding this comment.
Can we move this to its own node <selfgravity>. A few reasons: (1) it's only Cartesian unlike the other ones, (2) it complicates gravity's Initialize and (3) we have to be able to have both self-gravity and point mass gravity on at the same time.
pdmullen
commented
Dec 17, 2025
| const Real bdt = integrator->beta[stage - 1] * integrator->dt; | ||
|
|
||
| // Compute gravitational potential | ||
| if (do_gravity) Gravity::SolvePoisson(tc, pmesh); |
Collaborator
Author
There was a problem hiding this comment.
if (do_self_gravity)
src/gravity/gravity.cpp
Outdated
| psolver = | ||
| std::make_shared<parthenon::solvers::BiCGSTABSolver<PoissEq, preconditioner_t>>( | ||
| "base", "phi", "rhs", pin, block_name, PoissEq(pin, block_name)); | ||
| // psolver = std::make_shared<parthenon::solvers::MGSolver<PoissEq, prolongator_t>>( |
src/gravity/poisson_driver.cpp
Outdated
| @@ -0,0 +1,80 @@ | |||
| //======================================================================================== | |||
| // (C) (or copyright) 2023. Triad National Security, LLC. All rights reserved. | |||
Collaborator
Author
There was a problem hiding this comment.
Acknowledge parthenon poisson_gmg example
pdmullen
commented
Dec 17, 2025
| @@ -0,0 +1,113 @@ | |||
| //======================================================================================== | |||
Collaborator
Author
There was a problem hiding this comment.
this pgen isn't quite up-to-par... also need more formal testing (e.g., Jeans linear waves, Spitzer sheet, etc...)
Comment on lines
+66
to
+68
| const Real xp = coords.template Xc<dir>(k + koff, j + joff, i + ioff); | ||
| const Real xc = coords.template Xc<dir>(k, j, i); | ||
| const Real xm = coords.template Xc<dir>(k - koff, j - joff, i - ioff); |
Collaborator
There was a problem hiding this comment.
Can we use our coordinates object here and elsewhere in this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Description of Changes
Checklist