Add crooked pipe #110
Open
Add crooked pipe #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add pgen/crooked_pipe.hpp with specific geometric crooked pipe density and source parameters + Update list in params.yaml to include crooked pipe input options and defaults + Update if/else list in pgen.hpp to include crooked_pipe
+ Add crooked pipe input file
| // * density of thin regions using rho_thin | ||
| // * density of thick regions using rho_thick | ||
| // * initial material and radiation temperature of all cell using t_init | ||
| if (do_imc) { |
Collaborator
There was a problem hiding this comment.
Suppose for moments, this if-check could be moved to be just around the jaybenne::InitializeRadiation invocation below.
+ Disable gas (don't merge!) + Fix regions in inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Description of Changes
Checklist