Skip to content

Conversation

@leslie2046
Copy link
Contributor

@leslie2046 leslie2046 commented Dec 30, 2025

Related Issues or Context

图片

This PR contains Changes to Non-Plugin

  • Documentation
  • Other

This PR contains Changes to Non-LLM Models Plugin

  • I have Run Comprehensive Tests Relevant to My Changes

This PR contains Changes to LLM Models Plugin

  • My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
  • My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node)
  • My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)
  • My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
  • My Changes Affect Structured Output Format (JSON, XML, etc.)
  • My Changes Affect Token Consumption Metrics
  • My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
  • Other Changes (Add New Models, Fix Model Parameters etc.)

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

  • I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)

Dify Plugin SDK Version

  • I have Ensured dify_plugin>=0.3.0,<0.6.0 is in requirements.txt (SDK docs)

Environment Verification (If Any Code Changes)

Local Deployment Environment

  • Dify Version is: , I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration.

SaaS Environment

  • I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 30, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @leslie2046, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the Minimax Text-to-Speech (TTS) plugin by integrating the new speech-2.6 models and modernizing the voice management system. By transitioning from static YAML definitions to dynamic API calls for voice retrieval, the plugin now offers a more flexible and up-to-date selection of voices, enhancing the overall TTS capabilities.

Highlights

  • New Speech Models Added: Introduced two new Minimax Text-to-Speech (TTS) models: speech-2.6-hd and speech-2.6-turbo, expanding the available speech synthesis options.
  • Dynamic Voice Fetching: The system now dynamically retrieves available voices for TTS models directly from the Minimax API, replacing the previous static YAML configurations. This ensures that the plugin always has access to the latest voice options.
  • Plugin Version Update: The Minimax plugin's version has been incremented from 0.0.9 to 0.0.10 in manifest.yaml.
  • Dependency Update: The dify_plugin dependency in requirements.txt has been updated to ~=0.7.1.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great improvement. It refactors the Minimax TTS model to dynamically fetch available voices from the API, which is much more maintainable than the previous hardcoded list. The addition of the new speech-2.6 models is also a welcome update. My review includes a few suggestions in tts.py to improve code clarity and robustness.

return model_entity.model_properties.get(ModelPropertyKey.MAX_WORKERS, 5)
return 5 # fallback

def get_tts_model_voices(self, model: str, credentials: dict, language: Optional[str] = None) -> list:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The model and language parameters are no longer used within this function after refactoring to fetch voices from the API. If the method signature is defined by a base class and cannot be changed, it's good practice to explicitly mark them as unused to improve code clarity and signal your intent to future readers. You could add a comment or assign them to _ at the beginning of the function.

@dosubot dosubot bot added the enhancement New feature or request label Dec 30, 2025
leslie2046 and others added 2 commits December 30, 2025 17:52
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2025
@hjlarry hjlarry merged commit e2a4f30 into langgenius:main Dec 30, 2025
1 check passed
@leslie2046 leslie2046 deleted the feat/minimax branch December 30, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants