Skip to content

Conversation

@langfuse-bot
Copy link
Collaborator

@langfuse-bot langfuse-bot commented Feb 10, 2026

Important

Add observationId filter to GetScoresRequest and update ScoreV2 class to handle it.

  • Behavior:
    • Add observationId parameter to GetScoresRequest for filtering scores by observation IDs.
    • Update ScoreV2 class in Client.ts to handle observationId in query parameters.
  • Misc:
    • Update comments in GetScoresRequest.ts to document observationId usage.

This description was created by Ellipsis for d1af653. You can customize this summary. It will automatically update as commits are pushed.

Disclaimer: Experimental PR review

Greptile Overview

Greptile Summary

Adds support for filtering V2 scores by observation IDs. This updates the generated GetScoresRequest type to include an optional observationId (documented as a comma-separated list) and forwards that value through ScoreV2.get() into the request query parameters for GET /api/public/v2/scores.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The change is a straightforward, generated-client update: adding a new optional request field and forwarding it to query parameters, with no behavior changes unless observationId is provided.
  • No files require special attention

Important Files Changed

Filename Overview
packages/core/src/api/api/resources/scoreV2/client/Client.ts Adds observationId to GetScoresRequest destructuring and forwards it as a query parameter in ScoreV2.get().
packages/core/src/api/api/resources/scoreV2/client/requests/GetScoresRequest.ts Adds optional observationId?: string filter (documented as comma-separated IDs) to the GetScoresRequest interface.

Sequence Diagram

sequenceDiagram
  participant U as User Code
  participant C as Langfuse JS Client
  participant S as ScoreV2
  participant API as Langfuse API

  U->>C: client.scoreV2.get({ observationId, ... })
  C->>S: ScoreV2.get(request, options)
  S->>S: Build queryParameters incl. observationId
  S->>API: GET /api/public/v2/scores?observationId=...
  API-->>S: 200 GetScoresResponse
  S-->>U: data + rawResponse
Loading

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
langfuse-js Ready Ready Preview Feb 10, 2026 5:40pm

Request Review

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@sumerman sumerman merged commit 26b811b into main Feb 11, 2026
10 checks passed
@sumerman sumerman deleted the api-spec-bot-270f036 branch February 11, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants