fix(cli): warn when services partially start instead of false success#1115
Open
JasonOA888 wants to merge 1 commit intolangflow-ai:mainfrom
Open
fix(cli): warn when services partially start instead of false success#1115JasonOA888 wants to merge 1 commit intolangflow-ai:mainfrom
JasonOA888 wants to merge 1 commit intolangflow-ai:mainfrom
Conversation
Fixes langflow-ai#1102 ## Root Cause CLI always printed '✓ All services started' after asyncio.run(), regardless of whether docling or container services actually started successfully. ## Solution - Return (all_success, failed_services) from async _inner() - Check status after completion - Show warning on partial startup instead of false success - Guide users to check status for details ## Changes - src/tui/cli.py: _start_services_cli() ## Testing - [x] All services success → '✓ All services started' - [x] Docling fails → '⚠ Partial startup: 1 service(s) failed' - [x] Container fails → Warning shown, no false success ## Impact Users now get accurate feedback when startup is incomplete.
github-actions
bot
added
community
backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1102
Root Cause
CLI always printed '✓ All services started' after asyncio.run(), regardless of whether docling or container services actually started successfully.
Solution
Changes
Testing
Impact
Users now get accurate feedback when startup is incomplete.