Allow rerank kwargs on compress#139
Open
Tyler Britten (tybritten) wants to merge 1 commit intolangchain-ai:mainfrom
Open
Allow rerank kwargs on compress#139Tyler Britten (tybritten) wants to merge 1 commit intolangchain-ai:mainfrom
Tyler Britten (tybritten) wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
Tyler Britten (tybritten)
requested review from
a team,
Anirudh31415926535,
Beatrix De Wilde (BeatrixCohere),
Ads Dawson (GangGreenTemperTatum),
billytrend-cohere,
harry-cohere,
Minjie (minjie-cohere) and
pat-cohere
as code owners
Anirudh31415926535
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS Bedrock Cohere requires
max_tokens_per_docon the rerank call- cannot be Null.self.rerankallows configuration of it, but it doesn't make it tocompress_document function. This allows kwargs to be passed to rerank to allow that.