Keep the document ID when reranking#131
Open
Paul A. (Wecoreator) wants to merge 1 commit intolangchain-ai:mainfrom
Open
Keep the document ID when reranking#131Paul A. (Wecoreator) wants to merge 1 commit intolangchain-ai:mainfrom
Paul A. (Wecoreator) wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
LangChain Documents now have the Optional Field id for the BaseMedia class, which the Document class inherits. With this change, the id is no longer lost when reranking. Signed-off-by: Paul A. <73607727+Wecoreator@users.noreply.github.com>
Paul A. (Wecoreator)
requested review from
a team,
Anirudh31415926535,
Beatrix De Wilde (BeatrixCohere),
Ads Dawson (GangGreenTemperTatum),
billytrend-cohere,
harry-cohere,
Minjie (minjie-cohere) and
pat-cohere
as code owners
Author
|
Any update on this pull request? :) |
Collaborator
|
Hi Paul A. (@Wecoreator) Thanks so much for the change! Could you please add a test case to track this so that we can ensure it doesn't get lost later on? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LangChain Documents now have the Optional Field id for the BaseMedia class, which the Document class inherits.
With this change, the id is no longer lost when reranking.