This repository was archived by the owner on Jan 12, 2020. It is now read-only.
Draft
Conversation
Contributor
|
I took a look at this today. Looks like a good start. We need to be able to fetch more data from the backend for a slider like this to be useful though. That's blocked on lanebreach/lanebreach-api#40 because the amount of data that we fetch ends up being uncompressed and taking way too much time to send. There's a bunch of better architectural changes that we need to implement between frontend and backend, but even sending compressed data will be enough to increase the latency here considerably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, slider works but there's a minor bug with the default month displayed. Should also probably call the filter function on load by the current month