fix: Compare versions in the right order so that lando setup is run if it is set and we are >= 3.24 and the -slim versions do not exist anymore#108
Open
florianPat wants to merge 6 commits intolando:mainfrom
Conversation
…f it is set and we are >= 3.24 and the -slim download still works
✅ Deploy Preview for setup-lando ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for get-lando canceled.
|
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Lando setup was not run, even if SETUP=1 because of the compare_version call.
No, it runs for any version which is greater than 3.23.999, as the 3.23 branch did not need it. Also, only for this condition the "-slim" binary is downloaded if FAT is not set, because that does not exist as of 3.24.
Bare minimum self-checks
mainPieces of flare
Finally
Note
Adjusts POSIX installer logic for Lando 3 around the 3.24 cutoff and adds CI coverage.
setup-lando.sh, fixes version comparison and conditions so-slimis appended only for<3.24and autosetup is not disabled for>=3.24.github/workflows/pr-posix-script-slim-url-logic-tests.ymlto verify: no-slimsuffix for3.24+(3.24.0, 3-stable, 3-edge) and-slimsuffix for pre-3.24 (v3.23.0, v3.21.0-beta.10)Written by Cursor Bugbot for commit 44dd8ae. This will update automatically on new commits. Configure here.