sh: errexit support #581
Open
sh: errexit support #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `OPT_e` (errexit) to global options. - Add `ERREXIT_OK` flag to `struct sh_pipeline` to track execution context at parse time. - Update `set_main` to handle `set -e`, `set +e`, `set -o errexit`, `set +o errexit`. - Fix `set -o` logic where options were incorrectly disabled. - Update `parse_line` and `add_pl` to identify contexts where errexit should be ignored (`if`, `while`, `&&`, `||`, `!`). - Update `run_lines` to perform the exit check after command execution. - Update `run_subshell` to disable errexit for command substitution `$()`.
alganet
force-pushed
the
errexit-support
branch
from
60f87c3 to
45befd4
Compare
Author
|
I updated the initial idea to be more in line with the existing code, moved errexit checks to parse time, and removed the attempt at fixing the recursion stuff (realized those are probably unfinished ideas I have no business messing with). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set -o <flagname>in order to test itrecursion tests were failing, added a fix