-
Notifications
You must be signed in to change notification settings - Fork 6
Add methods for linking a keyring to another keyring #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is an important keyctl operation that can have implications on whether a key is readable and shows up in Search operations. It may not be immediately be apparent that this is a supported operation when calling KEYCTL_LINK, you have to dig through the docs to find this. man 7 keyrings: > As previously mentioned, keyrings are a special type of key that contains links to other keys (which may include other keyrings). Keys may be linked to by multiple keyrings.
|
This one is a little thrown together, I'm willing to rework it and do it differently (e.g. we could make it possible to convert a I do think there does need to be a supported way to link keyrings. Also willing to add tests and improve the comments if you can do a cursory review and say what's needed. |
|
@afontenot Thanks for the PR! I think your explicit methods are better than having users convert to a raw ID and using existing Key methods to workaround it. It looks clean, some tests would be great though. I'll try to get to these PRs this weekend. |
Also fixes a minor doc issue in previous commit
|
@landhb tests have been added. Implementing |
|
Sorry for the delay. I'll try to review the 3 open PRs and cut a release soon. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 78.33% 69.09% -9.24%
==========================================
Files 9 9
Lines 420 343 -77
==========================================
- Hits 329 237 -92
- Misses 91 106 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @afontenot ! |
This is an important keyctl operation that can have implications on whether a key is readable and shows up in Search operations.
It may not be immediately be apparent that this is a supported operation when calling KEYCTL_LINK, you have to dig through the docs to find this.
man 7 keyrings: