Skip to content

Conversation

@dcfocus
Copy link
Contributor

@dcfocus dcfocus commented Jan 14, 2026

Adds COLLECT() aggregation that collects values into an array, translating to DataFusion's array_agg function.

  • Add collect case in to_df_value_expr for DataFusion translation
  • Update contains_aggregate to recognize collect
  • Update semantic validation to allow COLLECT with bare variables
  • Add tests for COLLECT with and without grouping

Adds COLLECT() aggregation that collects values into an array,
translating to DataFusion's array_agg function.

- Add collect case in to_df_value_expr for DataFusion translation
- Update contains_aggregate to recognize collect
- Update semantic validation to allow COLLECT with bare variables
- Add tests for COLLECT with and without grouping
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...t/lance-graph/src/datafusion_planner/expression.rs 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@beinan beinan merged commit 1923f42 into lance-format:main Jan 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants