Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the monolithic solana-sdk and solana-client dependencies and replaces them with more granular Solana crate dependencies. This refactoring helps reduce the dependency footprint and makes the codebase more modular by only importing the specific functionality needed.
Changes:
- Replaced
solana-sdkwith multiple granular dependencies (solana-clock, solana-pubkey, solana-signature, solana-transaction, etc.) - Updated import statements across 17 files to use the new dependency paths
- Made unrelated RocksDB configuration changes (increased buffer sizes and added explanatory comments)
Reviewed changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Removed solana-sdk and solana-client; added 10 granular Solana dependencies |
| Cargo.lock | Updated dependency tree with new granular dependencies and removed unused transitive dependencies |
| src/storage/write.rs | Updated Slot import from solana_sdk to solana_clock |
| src/storage/sync.rs | Updated Slot import from solana_sdk to solana_clock |
| src/storage/source.rs | Updated imports for Slot and ClientError to use granular dependencies |
| src/storage/slots.rs | Updated Slot import from solana_sdk to solana_clock |
| src/storage/rocksdb.rs | Updated multiple imports; includes unrelated RocksDB configuration changes |
| src/storage/read.rs | Updated imports for clock types, Pubkey, Signature, and TransactionError |
| src/storage/memory.rs | Updated Slot import from solana_sdk to solana_clock |
| src/storage/blocks.rs | Updated clock-related imports from solana_sdk to solana_clock |
| src/source/transaction.rs | Updated imports for Slot, Signature, and TransactionError |
| src/source/stream.rs | Updated Slot import from solana_sdk to solana_clock |
| src/source/sfa.rs | Updated multiple imports to use granular dependencies; formatting issue |
| src/source/http.rs | Updated extensive imports from solana-client and solana-sdk to granular dependencies |
| src/source/fees.rs | Updated Pubkey and compute budget related imports |
| src/source/block.rs | Updated imports for clock types, Pubkey, Signature, and TransactionError |
| src/rpc/upstream.rs | Updated imports for Epoch, Slot, Pubkey, and Signature |
| src/rpc/api_jsonrpc.rs | Updated multiple imports including MAX_TX_ACCOUNT_LOCKS path change |
| src/rpc/api_httpget.rs | Updated Slot and Signature imports |
| src/bin/bench.rs | Updated Slot import from solana_sdk to solana_clock |
| CHANGELOG.md | Added entry documenting the dependency change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.