Close PR - No changes needed, boundary check correctly implemented#100
Closed
Copilot wants to merge 1 commit intofix-get-blocksfrom
Closed
Close PR - No changes needed, boundary check correctly implemented#100Copilot wants to merge 1 commit intofix-get-blocksfrom
Copilot wants to merge 1 commit intofix-get-blocksfrom
Conversation
Copilot
AI
changed the title
[WIP] Fix boundary check in get_blocks implementation
Close PR - No changes needed, boundary check correctly implemented
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created to address a review comment on #99 regarding a missing boundary check for
RpcRequestBlocksUntil::EndSlotin theget_blocksimplementation.Resolution
The boundary check is correctly implemented on line 354:
This check handles both
EndSlotandLimitcases by breaking the loop when any block exceedsend_slot, making a separate match on theuntilparameter unnecessary. The original review comment was incorrect.No code changes are required. This PR can be closed.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.