Skip to content

add type hints to docblock, add a verb to Exception message#13

Merged
weierophinney merged 1 commit intolaminas:masterfrom
rieschl:docblock-typehints
May 20, 2020
Merged

add type hints to docblock, add a verb to Exception message#13
weierophinney merged 1 commit intolaminas:masterfrom
rieschl:docblock-typehints

Conversation

@rieschl
Copy link
Copy Markdown
Contributor

@rieschl rieschl commented Mar 14, 2020

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Add missing type hints to AbstractControllerTestCase::assertApplicationException().

This was PR zendframework/zend-test#80 before migrating to Laminas.

@michalbundyra michalbundyra linked an issue Mar 22, 2020 that may be closed by this pull request
@michalbundyra michalbundyra added the Bug Something isn't working label Mar 22, 2020
@rieschl
Copy link
Copy Markdown
Contributor Author

rieschl commented May 20, 2020

@michalbundyra Is there anything I can/should do here?

weierophinney added a commit that referenced this pull request May 20, 2020
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney merged commit e42db4e into laminas:master May 20, 2020
weierophinney added a commit that referenced this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add type hints to docblock, add a verb to Exception message

3 participants