Skip to content

Tidy up #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Rantti wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Tidy up #2

Rantti wants to merge 15 commits into from

Conversation

@Rantti
Copy link
Contributor

@Rantti Rantti commented Sep 28, 2019

No description provided.

NikoGrano
NikoGrano requested changes Sep 29, 2019
View reviewed changes
Copy link
Member

@NikoGrano NikoGrano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge current master into this and check if changes are still required. If not. Close the PR.

@NikoGrano NikoGrano added the enhancement New feature or request label Oct 1, 2019
@majkrzak
Copy link
Contributor

majkrzak commented Oct 1, 2019

@Niko9911 first #3 have to be merged

@NikoGrano
Copy link
Member

NikoGrano commented Oct 1, 2019

@majkrzak Interesting to have newer PR first merged before older PR can be merged 😆

@NikoGrano
Copy link
Member

NikoGrano commented Oct 6, 2019

@majkrzak

We should have labelled this as October hackathon

@NikoGrano
Copy link
Member

NikoGrano commented Oct 21, 2019

If possible, please do something for this or close. Let's not leave dead PRs hanging around till next hackaton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikoGrano NikoGrano NikoGrano requested changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rantti @majkrzak @NikoGrano