Clickable error locations #73
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via the UI source maps feature we already have a way to open files from the browser. This re-uses that feature to make error locations in compile error messages clickable.
I needed to adjust the open editor feature a little to be able to re-use it. I ended up cleaning up that feature quite a bit, making it more prepared for vanilla Elm app use-cases (where we shouldn’t assume that the only source directory is called
srcfor example). Bonus improvements:::instead ofList.appendfor performance. (Remember that we do this on every element attribute list.)Note: When building, you need to add something like the following to
StaticFiles.hsto bust cache: