Set related_name of created_by and updated_by fields according to mod…#20
Open
tcx9871 wants to merge 2 commits intolambdalisue:masterfrom
Open
Set related_name of created_by and updated_by fields according to mod…#20tcx9871 wants to merge 2 commits intolambdalisue:masterfrom
tcx9871 wants to merge 2 commits intolambdalisue:masterfrom
Conversation
2 similar comments
…el app_label and class_name. This allows usage with abstract models.
Collaborator
|
I have tested this, but it changes the related names of the related fields. It changes the This would either need to go through some deprecation process, or better it should stay compatible. |
PetrDlouhy
requested changes
Aug 22, 2022
Collaborator
PetrDlouhy
left a comment
PetrDlouhy
left a comment
There was a problem hiding this comment.
I have tested this, but it changes the related names of the related fields. It changes the asset_create into assets_asset_create, so it is incompatible with current implementations.
This would either need to go through some deprecation process, or better it should stay compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…el app_label and class_name. This allows usage with abstract models.