feat: Making the InChI FAIR and sustainable while moving to inorganics paper#38
Open
NRayya wants to merge 1 commit intolamalab-org:mainfrom
Open
feat: Making the InChI FAIR and sustainable while moving to inorganics paper#38NRayya wants to merge 1 commit intolamalab-org:mainfrom
NRayya wants to merge 1 commit intolamalab-org:mainfrom
Conversation
Contributor
Reviewer's GuideThis PR augments the project’s bibliography with key foundational and recent works—including the new Blanke et al. 2025 InChI FAIR article—and scaffolds a dedicated Quarto document for discussing FAIR and sustainable InChI support in inorganics. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @NRayya - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+1062
to
+1064
| year={2025}, | ||
| publisher={Royal Society of Chemistry} | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion: Drop 'publisher' field from @Article entries
The 'publisher' field is unnecessary for journal articles in BibTeX and should be omitted for correctness and clarity.
Suggested change
| year={2025}, | |
| publisher={Royal Society of Chemistry} | |
| } | |
| year={2025} | |
| } |
Comment on lines
+1066
to
+1071
| @book{engel2018chemoinformatics, | ||
| title={Chemoinformatics: basic concepts and methods}, | ||
| author={Engel, Thomas and Gasteiger, Johann}, | ||
| year={2018}, | ||
| publisher={John Wiley \& Sons} | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion: Include ISBN for book entries
ISBNs ensure unique identification and better compatibility with bibliography tools.
Suggested change
| @book{engel2018chemoinformatics, | |
| title={Chemoinformatics: basic concepts and methods}, | |
| author={Engel, Thomas and Gasteiger, Johann}, | |
| year={2018}, | |
| publisher={John Wiley \& Sons} | |
| } | |
| @book{engel2018chemoinformatics, | |
| title={Chemoinformatics: basic concepts and methods}, | |
| author={Engel, Thomas and Gasteiger, Johann}, | |
| year={2018}, | |
| publisher={John Wiley \& Sons}, | |
| isbn={9783527331093} | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add initial draft of the 'InChI FAIR and sustainable inorganics' manuscript and enrich the project bibliography with five new relevant references.
Enhancements:
Documentation: