Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Reviewer's GuideIntroduces a new Jupyter notebook implementing the ChemTEB retrieval and evaluation pipeline: it loads the ChemHotpotQARetrieval dataset, generates and persists embeddings via the OpenAI API, defines DCG/NDCG metrics, computes cosine-similarity–based retrieval, and reports mean NDCG@10. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @kjappelbaum - I've reviewed your changes - here's some feedback:
- Strip the notebook outputs and migrate the core retrieval logic into reusable Python modules or scripts for better maintainability and reviewability.
- Use batched embedding requests and vectorized numpy or sklearn cosine-similarity computations instead of per-item loops to improve performance and avoid API rate limits.
- Fix the inconsistent filename when loading saved embeddings (e.g. ‘cqueries_embeddings.npy’) and consider parameterizing file paths rather than hard-coding them.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Strip the notebook outputs and migrate the core retrieval logic into reusable Python modules or scripts for better maintainability and reviewability.
- Use batched embedding requests and vectorized numpy or sklearn cosine-similarity computations instead of per-item loops to improve performance and avoid API rate limits.
- Fix the inconsistent filename when loading saved embeddings (e.g. ‘cqueries_embeddings.npy’) and consider parameterizing file paths rather than hard-coding them.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add a Jupyter notebook implementing the ChemTEB baseline for chemical QA retrieval using OpenAI embeddings and evaluate performance with NDCG@10.
New Features: