Improve framework detection by searching subdirectories for package.json#45
Open
Improve framework detection by searching subdirectories for package.json#45
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: lak7#43
|
@konard is attempting to deploy a commit to the lak7's projects Team on Vercel. A member of the Team first needs to authorize it. |
When package.json is not found in the repository root, use the Git tree API to recursively search subdirectories and pick the shallowest match. This handles monorepos and projects where the main app lives in a subdirectory. Fixes lak7#43 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
konard
changed the title
This reverts commit 0e27d69.
Contributor
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonis not found in the repository root directory, the code now searches subdirectories using the GitHub Git tree API (recursive)package.jsonfound in subdirectories (closest to root), which handles monorepos and nested project structurescheckPackageAndFramework()inactions/reverse-architecture.tsand the import API route insrc/app/api/github/import/route.tsProblem
Previously, if
package.jsonwas not in the root directory, the framework detection would either report "Error fetching package.json" or return{ isValid: false, framework: "" }, making it impossible to analyze repositories where the main application lives in a subdirectory.Test plan
package.jsonin root (should work as before)package.jsonis in a subdirectory (e.g.,frontend/package.json)package.jsonat all (should still returnisValid: false)Fixes #43
🤖 Generated with Claude Code